add more mssql datatypes #19105
Merged
add more mssql datatypes #19105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Apr 18, 2024
test/modules/post/test/mssql.rb
Outdated
| @@ -41,6 +41,57 @@ def test_console_query | |||
| end | |||
| end | |||
|
|
|||
| def test_datatypes | |||
| it "should support datetime TDS datatype" do | |||
There was a problem hiding this comment.
Maybe instead of string matching the console we should test the Ruby result
[
query: 'select cast(null as datetime);', expected: [[nil]],
query: 'select cast('1990-01-02' as datetime);', expected: [['1990-01-02']],
...
].each do |test|
it "should execute the query #{test[:query]} and return #{test[:expected]}" do
ret = console.client.query(test[:query]) == test[:expected]
end
endWhich would make it easier to add more tests in the future, as well as ensuring we can test the nil scenarios
zgoldman-r7
force-pushed
the
add-more-mssql-datatypes
branch
from
b4e9bf2 to
1ff7d47
Compare
adfoster-r7
reviewed
Apr 18, 2024
zgoldman-r7
force-pushed
the
add-more-mssql-datatypes
branch
2 times, most recently
from
2362138 to
1050840
Compare
adfoster-r7
reviewed
Apr 19, 2024
test/modules/post/test/mssql.rb
Outdated
| {query: "select cast('1999999900' as numeric(16, 6));", expected: [[1999999900.0]]}, | ||
| {query: "select cast(null as numeric(16, 6));", expected: [[nil]]}, | ||
| ].each do |test| | ||
| it "should execute the query #{test[:query]} and return #{test[:expected] || 'nil'}" do |
There was a problem hiding this comment.
This would mark false as nil
Suggested change
| it "should execute the query #{test[:query]} and return #{test[:expected] || 'nil'}" do | |
| it "should execute the query #{test[:query]} and return #{test[:expected].inspect}" do |
adfoster-r7
reviewed
Apr 19, 2024
zgoldman-r7
force-pushed
the
add-more-mssql-datatypes
branch
from
1050840 to
7659f52
Compare
zgoldman-r7
force-pushed
the
add-more-mssql-datatypes
branch
from
7659f52 to
b4dccdf
Compare
Release NotesUpdates MSSQL modules to support querying multiple new column types: float, real, money, smallmoney, datetime, smalldatetime, and numeric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for 7 new datatypes for MSSQL: float, real, money, smallmoney, datetime, smalldatetime, and numeric.
To test this, make sure you can connect to a remote mssql session, either via docker or VM.
use mssql_sqlrun with credentials/connection info to the MSSQL instance, setting
sqlto a query that returns one of the new datatypes. ie:checking null as well
Validate that output response looks okay